Skip to content

ELB: added UDP to list of supported protocols - #79

Merged
otc-zuul[bot] merged 1 commit into
opentelekomcloud:masterfrom
spielkind:feature/support_udp_for_loadbalancer
Apr 24, 2020
Merged

ELB: added UDP to list of supported protocols#79
otc-zuul[bot] merged 1 commit into
opentelekomcloud:masterfrom
spielkind:feature/support_udp_for_loadbalancer

Conversation

@spielkind

Copy link
Copy Markdown
Contributor

Addded UDP to client as it's supported by the API:
https://docs.otc.t-systems.com/api/elb/en-us_topic_0132469642.html

@otc-zuul

otc-zuul Bot commented Apr 23, 2020

Copy link
Copy Markdown
Contributor

Build failed.

@gtema

gtema commented Apr 24, 2020

Copy link
Copy Markdown
Collaborator

thanks @spielkind for the PR. Nobody from us has ever tried UDP LB so far, but let's fix this if somebody really needs it.

  1. you have flake8 (pep8) validation errors (lines over 80 chars). You can verify this by running "tox -e pep8". Please fix this.
  2. You have now a test failure, since there is a test "otcextensions.tests.unit.osclient.load_balancer.v1.test_listener.TestListListener.test_list_filters_exceptions_proto" (otcextensions/tests/unit/osclient/load_balancer/v1/test_listener.py", line 123, in test_list_filters_exceptions_proto), which funnily checks, that UDP is not supported type (it picks any value from the unsupported types. So just change listener type argument to be not UDP, but rather something really unsupported

We might be willing to add some functional tests in the LB area as well, but we can merge you PR beforehand (after errors are fixed)

@spielkind

spielkind commented Apr 24, 2020

Copy link
Copy Markdown
Contributor Author

@gtema thx, I'll look into that.

We need that because we want to have the same Port as UDP & TCP as different listeners on the same Loadbalancer. The OTC WebIF doesn't allow us to configure this (duplicate port) which is kind of stupid/a bug. But through CLI this is not a problem.

The CLI implementation is also missing other parts like 'monitor_port' & 'domain_name' for the healthmonitor.

Also regarding supported protocols for listeners: HTTPS is not supported regarding API documentation, but TERMINATED_HTTPS is.
https://docs.otc.t-systems.com/api/elb/en-us_topic_0096561483.html

Probably the whole loadbalancer code needs some love. :)

@spielkind
spielkind force-pushed the feature/support_udp_for_loadbalancer branch from dd64a34 to ba0b059 Compare April 24, 2020 08:55
@otc-zuul

otc-zuul Bot commented Apr 24, 2020

Copy link
Copy Markdown
Contributor

Build succeeded.

@gtema

gtema commented Apr 24, 2020

Copy link
Copy Markdown
Collaborator

/merge

@otc-zuul

otc-zuul Bot commented Apr 24, 2020

Copy link
Copy Markdown
Contributor

Build succeeded.

@otc-zuul
otc-zuul Bot merged commit aa02891 into opentelekomcloud:master Apr 24, 2020
vineet-pruthi pushed a commit to fkukucsk/python-otcextensions that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants